linux-kernel - Re: VIRTIO_BLK_T_SCSI_CMD handling in virtio-blk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200903181037.16043.borntraeger@de.ibm.com>
Date:	Wed, 18 Mar 2009 10:37:15 +0100
From:	Christian Borntraeger <borntraeger@...ibm.com>
To:	Hannes Reinecke <hare@...e.de>
Cc:	Christoph Hellwig <hch@...radead.org>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Anthony Liguori <aliguori@...ibm.com>,
	linux-kernel@...r.kernel.org
Subject: Re: VIRTIO_BLK_T_SCSI_CMD handling in virtio-blk

Am Wednesday 18 March 2009 10:16:43 schrieb Hannes Reinecke:
> -               end_dequeued_request(vbr->req, uptodate);
> +               if (blk_pc_request(vbr->req)) {
> +                       vbr->req->data_len = vbr->in_hdr.residual;
> +                       bytes = vbr->in_hdr.data_len;
> +                       vbr->req->sense_len = vbr->in_hdr.sense_len;
> +                       vbr->req->errors = vbr->in_hdr.status;
> +               } else


I think we identified a bug in the old patch:
http://kerneltrap.org/mailarchive/linux-kvm/2008/8/29/3127594
http://kerneltrap.org/index.php?q=mailarchive/linux-kvm/2008/8/29/3128124

Is this fixup still valid? 

-		if (blk_pc_request(vbr->req)) {
+		if (blk_pc_request(vbr->req) && len >= sizeof(vbr->in_hdr)) {

I forgot almost all details about the problem.

Christian