linux-kernel - RE: [PATCH] dmaengine: Add Kconfig of DMA data align for DMA Test driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <129600E5E5FB004392DDC3FB599660D786B0DFC5@irsmsx504.ger.corp.intel.com>
Date:	Wed, 18 Mar 2009 12:09:52 +0000
From:	"Sosnowski, Maciej" <maciej.sosnowski@...el.com>
To:	"Williams, Dan J" <dan.j.williams@...el.com>,
	Nobuhiro Iwamatsu <iwamatsu.nobuhiro@...esas.com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Haavard Skinnemoen <hskinnemoen@...el.com>
Subject: RE: [PATCH] dmaengine: Add Kconfig of DMA data align for DMA Test
 	driver

Dan Williams wrote:
> On Wed, Mar 11, 2009 at 11:30 PM, Nobuhiro Iwamatsu
> <iwamatsu.nobuhiro@...esas.com> wrote:
>> Test drivers of DMA engine usually perform DMA transfer by 1 byte
>> unit. This can set transfer size of DMA and aligns data for tests.
>> 
>> Signed-off-by: Nobuhiro Iwamatsu <iwamatsu.nobuhiro@...esas.com>
>> Cc: Haavard Skinnemoen <hskinnemoen@...el.com>
>> Cc: Maciej Sosnowski <maciej.sosnowski@...el.com>
>> Cc: Dan Williams <dan.j.williams@...el.com>
>> ---
> 
> This should just be a module parameter, and it needs error handling
> for the alignment > transfer length case.
> 
> Thanks,
> Dan

I agree with Dan. Align size should be rather module parameter.

Regards,
Maciej--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/