linux-kernel - Re: [PATCH] BTRFS: Transpose parent_objectid and parent_gen in struct btrfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1237396909.27829.102.camel@macbook.infradead.org>
Date:	Wed, 18 Mar 2009 17:21:49 +0000
From:	David Woodhouse <dwmw2@...radead.org>
To:	David Howells <dhowells@...hat.com>
Cc:	Chris Mason <chris.mason@...cle.com>, balajirrao@...il.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] BTRFS: Transpose parent_objectid and parent_gen in
 struct btrfs_fid

On Wed, 2009-03-18 at 17:05 +0000, David Howells wrote:
> Chris Mason <chris.mason@...cle.com> wrote:
> 
> > Won't this confuse any handles the clients already have if the server
> > reboots with the new handle format?
> 
> Perhaps, but it's probably early enough in BTRFS's life to get away with it.

True. It's not that hard to handle compatibility if we really care,
either.

But this struct is packed anyway -- we're not changing much on the wire;
it's just a case of how efficient it is to load that single uint64_t
from an unaligned location. Is that _really_ something we're ever going
to notice?

-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse@...el.com                              Intel Corporation

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/