linux-kernel - Re: [tip:tracing/ftrace] ftrace: remove struct list_head from struct dyn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <49C06159.9010704@cn.fujitsu.com>
Date:	Wed, 18 Mar 2009 10:50:01 +0800
From:	Lai Jiangshan <laijs@...fujitsu.com>
To:	Frederic Weisbecker <fweisbec@...il.com>
CC:	mingo@...hat.com, hpa@...or.com, linux-kernel@...r.kernel.org,
	srostedt@...hat.com, tglx@...utronix.de, mingo@...e.hu,
	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:tracing/ftrace] ftrace: remove struct list_head from	struct
 dyn_ftrace

Frederic Weisbecker wrote:
> 
> 
> May be I'm wrong. May be I misunderstood this patch.
> But I don't understand how flags can be used at the same time as a pointer
> and as a flag value.
> 

When a new dyn_ftrace is added to ftrace_new_addrs list, the flag is 0,
it's always 0 until this dyn_ftrace is removed from the list, so we can
reuse the flag field. As Steven's suggest, using an union is better.

ftrace_convert_nops()
  ftrace_record_ip() // allocate dyn_ftrace, and add it
                     // to ftrace_new_addrs list
  ftrace_update_code() // remove it from ftrace_new_addrs.

Lai.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/