linux-kernel - Re: [PATCH 24/27] Convert gfp_zone() to use a table of precalculated values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090318194604.GD24462@csn.ul.ie>
Date:	Wed, 18 Mar 2009 19:46:04 +0000
From:	Mel Gorman <mel@....ul.ie>
To:	Christoph Lameter <cl@...ux-foundation.org>
Cc:	Linux Memory Management List <linux-mm@...ck.org>,
	Pekka Enberg <penberg@...helsinki.fi>,
	Rik van Riel <riel@...hat.com>,
	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	Johannes Weiner <hannes@...xchg.org>,
	Nick Piggin <npiggin@...e.de>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Lin Ming <ming.m.lin@...el.com>,
	Zhang Yanmin <yanmin_zhang@...ux.intel.com>,
	Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH 24/27] Convert gfp_zone() to use a table of
	precalculated values

On Wed, Mar 18, 2009 at 03:07:48PM -0400, Christoph Lameter wrote:
> On Wed, 18 Mar 2009, Mel Gorman wrote:
> 
> > Thanks.At a quick glance, it looks ok but I haven't tested it. As the intention
> > was to get one pass of patches that are not controversial and are "obvious",
> > I have dropped my version of the gfp_zone patch and the subsequent flag
> > cleanup and will revisit it after the first lot of patches has been dealt
> > with. I'm testing again with the remaining patches.
> 
> This fixes buggy behavior of gfp_zone so it would deserve a higher
> priority.
> 

It is buggy behaviour in response to a flag combination that makes no sense
which arguably is a buggy caller. Now that I get to think about it a bit more,
you can't define a const table in a header. If it's declared extern, then
the compiler doesn't know what the constant value is so it can't generate
better code.  At best, you end up with equivalent code to what my patch did
in the first place except __GFP_DMA32|__GFP_HIGHMEM will return ZONE_NORMAL.

-- 
Mel Gorman
Part-time Phd Student                          Linux Technology Center
University of Limerick                         IBM Dublin Software Lab
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/