linux-kernel - Re: [PATCH -tip] sched: Clean unused fields from struct rq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090318212015.GA6183@hades.domain.com>
Date:	Wed, 18 Mar 2009 21:20:15 +0000
From:	Luis Henriques <henrix@...o.pt>
To:	Gregory Haskins <ghaskins@...ell.com>
Cc:	Ingo Molnar <mingo@...e.hu>, Peter Zijlstra <peterz@...radead.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH -tip] sched: Clean unused fields from struct rq

Hi Greg,

On Wed, Mar 18, 2009 at 05:00:06PM -0400, Gregory Haskins wrote:
> I actually key off the SCHEDSTAT_VERSION (currently 14) at the top of
> kernel/sched_stats.h.  Cursory inspection of the existing code and your
> patch says that this should actually be the value that needs updating
> (vs. vSched-Debug).  However, note that I am not sure if there are also
> users of sched-debug that need to see that version bump as well in order
> to remain compatible.

Hmm... so, what's the relation between SCHEDSTAT_VERSION and the "Sched Debug"
version I update in my patch?  Assuming there is a relation... :-)

I believe that I actually need to update both versioning mechanims but I think
this is something odd -- either there is one mechanism to handle version or a
comment should clarify why there are two.

> If you are really motivated, you can test your patches against my
> schedtop tool to verify sane behavior (for bumping SCHEDSTAT_VERSION to
> 15, I would expect it to gracefully report that it cannot handle this
> version and exit).  You can find both source and rpms here:

Sure I will give it a try -- I'll let you know about the result.

Thanks!
-- 
Luis Henriques
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/