linux-kernel - Re: Microblaze linux support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1237459666.3127.8.camel@localhost.localdomain>
Date:	Thu, 19 Mar 2009 16:17:46 +0530
From:	Jaswinder Singh Rajput <jaswinder@...nel.org>
To:	monstr@...str.eu
Cc:	Ingo Molnar <mingo@...e.hu>, linux-kernel@...r.kernel.org,
	john.williams@...alogix.com,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: Microblaze linux support

On Thu, 2009-03-19 at 11:26 +0100, Michal Simek wrote:

> you are welcome - I can quickly test and add all changes to git.
> 
> Is it good style separate extern definition and EXPORT_SYMBOL?
> 
> I have three choices?
> 1. keep extern + EXPORT_SYMBOL below  - current style
> 2. move only extern to header file
> 3. move extern and EXPORT_SYMBOL to header.
> 
> What is preferable way?

externs should be in header files

EXPORT_SYMBOL should immediately follow its function/variable should
normally be in source files like : arch/x86/kernel/process.c
and if required can also be defined in header files like:
arch/x86/include/asm/percpu.h

--
JSR

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/