linux-kernel - Re: [PATCH] CRED: Fix check_unsafe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0903191839330.12886@blonde.anvils>
Date:	Thu, 19 Mar 2009 18:44:12 +0000 (GMT)
From:	Hugh Dickins <hugh@...itas.com>
To:	Joe Malicki <jmalicki@...acarta.com>
cc:	chrisw@...s-sol.org, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org,
	linux-security-module@...r.kernel.org,
	David Howells <dhowells@...hat.com>
Subject: Re: [PATCH] CRED: Fix check_unsafe_exec()

On Tue, 17 Mar 2009, Joe Malicki wrote:
> ----- "Joe Malicki" <jmalicki@...acarta.com> wrote:
> > ----- "Hugh Dickins" <hugh@...itas.com> wrote:
> > > Yes, I'm inclined to go with that, and removing the files->count
> > > check from exec.c.  Joe, did you manage to try your testing with
> > > my original patch plus that files->count check removed from 2.6.28's
> > > unsafe_exec()?
> > 
> > Sorry for not responding earlier.
> > 
> > I still got one failure with this new patch.  I added some printks
> > to illuminate exactly why it's failing when it fails to setuid, but
> > of course, since adding the printks I haven't reproduced yet.
> 
> My tests were accidentally run without removing the files->count check.

Oh good, thanks Joe, I was hoping that would be the case.

> The printks confirmed the failure case was the files->count check,
> and removing the files->check has worked thus far (though I can't be
> sure until after a day or two has gone by given how infrequent it is).

Okay, unless we hear bad news from you later, I'll post the set of three
patches (removing the files->count check, then my original fs->count one,
plus David's comment) in a day or two, adding a few more Ccs.

Hugh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/