linux-kernel - Re: [PATCH 02/13] async_tx: don't use src_list argument of async

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090319201008.GC10491@skl-net.de>
Date:	Thu, 19 Mar 2009 21:10:08 +0100
From:	Andre Noll <maan@...temlinux.org>
To:	Dan Williams <dan.j.williams@...el.com>
Cc:	linux-raid@...r.kernel.org, linux-kernel@...r.kernel.org,
	neilb@...e.de, maciej.sosnowski@...el.com,
	Yuri Tikhonov <yur@...raft.com>, Ilya Yanok <yanok@...raft.com>
Subject: Re: [PATCH 02/13] async_tx: don't use src_list argument of async_xor() for dma addresses

On 12:20, Dan Williams wrote:

> Using src_list argument of async_xor() as a storage for dma addresses
> implies sizeof(dma_addr_t) <= sizeof(struct page *) restriction which is
> not always true (e.g. ppc440spe).

This message does not tell what the patch is going to do about that.
It would also be nice to mention (either in the log message or as a
comment) why allocating the dma_src arrays on the stack is not going
to be a problem.

Andre
-- 
The only person who always got his work done by Friday was Robinson Crusoe

Download attachment "signature.asc" of type "application/pgp-signature" (190 bytes)