| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 18 Mar 2009 21:58:12 -0700 From: Arjan van de Ven <arjan@...radead.org> To: linux-input@...r.kernel.org Cc: dmitry.torokhov@...il.com, dipankar@...ibm.com, linux-kernel@...r.kernel.org Subject: Question about usage of RCU in the input layer Hi, the input layer does a "synchronize_rcu()" after a list_add_tail_rcu(), which is costing me 1 second of boot time..... And based on my understanding of the RCU concept, you only need to synchronize on delete, not on addition... so I think the synchronize is entirely redundant here... Can I have my second of boot time back please ? diff --git a/drivers/input/input.c b/drivers/input/input.c index 1730d73..d69ec56 100644 --- a/drivers/input/input.c +++ b/drivers/input/input.c @@ -1544,7 +1544,6 @@ int input_register_handle(struct input_handle *handle) return error; list_add_tail_rcu(&handle->d_node, &dev->h_list); mutex_unlock(&dev->mutex); - synchronize_rcu(); /* * Since we are supposed to be called from ->connect() -- Arjan van de Ven Intel Open Source Technology Centre For development, discussion and tips for power savings, visit http://www.lesswatts.org -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists