linux-kernel - [tip:core/iommu] dma-debug: warn of unmapping an invalid dma address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tip-35d40952dba7b0689a16bd1463fb7698f8dbe639@git.kernel.org>
Date:	Thu, 19 Mar 2009 07:42:23 GMT
From:	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
To:	linux-tip-commits@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, hpa@...or.com, mingo@...hat.com,
	joerg.roedel@....com, fujita.tomonori@....ntt.co.jp,
	tglx@...utronix.de, mingo@...e.hu
Subject: [tip:core/iommu] dma-debug: warn of unmapping an invalid dma address

Commit-ID:  35d40952dba7b0689a16bd1463fb7698f8dbe639
Gitweb:     http://git.kernel.org/tip/35d40952dba7b0689a16bd1463fb7698f8dbe639
Author:     FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
AuthorDate: Thu, 19 Mar 2009 10:39:31 +0900
Committer:  Ingo Molnar <mingo@...e.hu>
CommitDate: Thu, 19 Mar 2009 08:39:48 +0100

dma-debug: warn of unmapping an invalid dma address

Impact: extend DMA-debug checks

Calling dma_unmap families against an invalid dma address should be a
bug.

Signed-off-by: FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
Cc: Joerg Roedel <joerg.roedel@....com>
LKML-Reference: <20090319103743N.fujita.tomonori@....ntt.co.jp>
Signed-off-by: Ingo Molnar <mingo@...e.hu>


---
 lib/dma-debug.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/lib/dma-debug.c b/lib/dma-debug.c
index 9a350b4..f9e6d38 100644
--- a/lib/dma-debug.c
+++ b/lib/dma-debug.c
@@ -531,8 +531,11 @@ static void check_unmap(struct dma_debug_entry *ref)
 	struct hash_bucket *bucket;
 	unsigned long flags;
 
-	if (dma_mapping_error(ref->dev, ref->dev_addr))
+	if (dma_mapping_error(ref->dev, ref->dev_addr)) {
+		err_printk(ref->dev, NULL, "DMA-API: device driver tries "
+			   "to free an invalid DMA memory address\n");
 		return;
+	}
 
 	bucket = get_hash_bucket(ref, &flags);
 	entry = hash_bucket_find(bucket, ref);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/