linux-kernel - Re: linux-next: Tree for March 19 (media/au8522)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090319210633.6911eba1@pedra.chehab.org>
Date:	Thu, 19 Mar 2009 21:06:33 -0300
From:	Mauro Carvalho Chehab <mchehab@...radead.org>
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	linux-media@...r.kernel.org,
	Devin Heitmueller <devin.heitmueller@...il.com>
Subject: Re: linux-next: Tree for March 19 (media/au8522)

On Thu, 19 Mar 2009 10:11:30 -0700
Randy Dunlap <randy.dunlap@...cle.com> wrote:

> Stephen Rothwell wrote:
> > Hi all,
> > 
> > Changes since 20090318:
> 
> 
> au8522_decoder.c:(.text+0x199898): undefined reference to `v4l2_ctrl_query_fill'
> au8522_decoder.c:(.text+0x1998b3): undefined reference to `v4l2_ctrl_query_fill'
> au8522_decoder.c:(.text+0x199944): undefined reference to `v4l2_device_unregister_subdev'
> au8522_decoder.c:(.text+0x19997c): undefined reference to `v4l2_chip_ident_i2c_client'
> au8522_decoder.c:(.text+0x199f1e): undefined reference to `v4l2_i2c_subdev_init'
> 
Thanks! This were due to the fact that au8522 is now dependent on V4L2, since
the same chip is used for both DVB frontand and Analog demodulation.

Devin,

IMO, you have a bad design here: You should try to have a core module with the
common parts, and separate modules for the analog and the DVB parts of the chip.

Anyway, for now, I just added the required dependencies at the Kconfig.

Cheers,
Mauro

PS.: I'll be updating the linux-next patches later, after adding some other
stuff. So, you'll probably see the fix for those reported issues merged only
tomorrow.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/