linux-kernel - [PATCH] crypto/scatterwalk.c to skip unnecessary flush_dcache_page() calls which may cause kernel panic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <9c0b8b730903200115i7ae4512di97418958e05f6a0e@mail.gmail.com>
Date:	Fri, 20 Mar 2009 16:15:16 +0800
From:	Chung-Yih Wang (王崇懿) <cywang@...gle.com>
To:	linux-kernel@...r.kernel.org
Subject: [PATCH] crypto/scatterwalk.c to skip unnecessary flush_dcache_page() 
	calls which may cause kernel panic

I am developing the ipsec tools on ARM platform. When I turn the
 CONFIG_DEBUG_VM on, the ipsec traffic triggers the kernel panic
which is caused by the VM_DEBUG_ON(PageSlab(page)) of
page_mapping() in the call of flush_dcache_page().

The root cause is that ipsec/esp intends to encrypt the original
data and dynamically allocate cache memory in socket buffer for
this purpose. However, all the cache memory pages dynamically
allocated in socket buffer will be flagged as PG_slab by
__SetPageSlab(). That's the reason it asserts on
VM_BUG_ON(PageSlab(page)) in flush_dcache_page(). Since the
flush_dcache_page() is to ensure the cache coherency between
kernel mapping and userspace mapping. The kernel cache memory
created in socket buffer for encrypting ipsec traffic does not
need to call this function at all since it is all kernel space
data.

Below is my patch for fixing this bug for  CONFIG_DEBUG_VM=y.

Chung-yih

diff --git a/crypto/scatterwalk.c b/crypto/scatterwalk.c
index 9aeeb52..3de89a4 100644
--- a/crypto/scatterwalk.c
+++ b/crypto/scatterwalk.c
@@ -54,7 +54,8 @@ static void scatterwalk_pagedone(struct scatter_walk
*walk, int out,
                struct page *page;

                page = sg_page(walk->sg) + ((walk->offset - 1) >> PAGE_SHIFT);
-               flush_dcache_page(page);
+               if (!PageSlab(page))
+                       flush_dcache_page(page);
        }

        if (more) {
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/