linux-kernel - Re: [PATCH] Add SELinux context and TTY name to AUDIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 20 Mar 2009 04:53:27 -0400 (EDT)
From:	Miloslav Trmac <mitr@...hat.com>
To:	Paul Moore <paul.moore@...com>
Cc:	viro <viro@...iv.linux.org.uk>, Eric Paris <eparis@...hat.com>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	linux-audit@...hat.com
Subject: Re: [PATCH] Add SELinux context and TTY name to AUDIT_TTY records

Paul,
Thanks for your review.
----- "Paul Moore" <paul.moore@...com> wrote:
> There are several audit experts which should review this code but two
> things 
> jumped out at me when glancing at your patch:
> 
>  1. SELinux SIDs should not be recorded
Almost all code that logs SELinux contexts in kernel/audit* does the same thing as this patch, falling back to a SID if it can't be converted to a string.

>  2. From a SELinux/security point of view ttys are considered objects
>     and their labels/contexts should be recorded with "obj=" not
> "subj="
The patch logs the context of the process, not of the TTY.
    Mirek
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/