linux-kernel - Re: [PATCH 08/57] microblaze_v7: Interrupt handling, timer support, selfmod code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.0903201508470.29264@localhost.localdomain>
Date:	Fri, 20 Mar 2009 15:12:18 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Michal Simek <monstr@...str.eu>
cc:	LKML <linux-kernel@...r.kernel.org>, john.williams@...alogix.com,
	John Stultz <johnstul@...ibm.com>
Subject: Re: [PATCH 08/57] microblaze_v7: Interrupt handling, timer support,
 selfmod code

Michal,

On Fri, 20 Mar 2009, Michal Simek wrote:
> > I guess the problem is in your chip->xxx functions.
> 
> I fixed it. There were one additional line.
> + I set GENERIC_HARDIRQS_NO__DO_IRQ=y.

Cool.

> BTW: Below is full chip description where function enable is unmask
> and disable is mask. Do I have keep there enable and disable function pointers?
> I commented them and works without them too.

Right. The generic code does:

        if (!chip->enable)
                chip->enable = default_enable;
        if (!chip->disable)
                chip->disable = default_disable;

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/