linux-kernel - [PATCH] x86: fix IO APIC resource allocation error message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <200903202012.41344.bzolnier@gmail.com>
Date:	Fri, 20 Mar 2009 20:12:41 +0100
From:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Alan Bartlett <ajb.stxsl@...glemail.com>,
	linux-kernel@...r.kernel.org
Subject: [PATCH] x86: fix IO APIC resource allocation error message

From: Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
Subject: [PATCH] x86: fix IO APIC resource allocation error message

Impact: fix incorrect error message

- IO APIC resource allocation error message contains one too many "be".

- Print the error message iff there are IO APICs in the system.

Cc: Alan Bartlett <ajb.stxsl@...glemail.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
---
I've seen this error message for some time on my x86-32 laptop...

 arch/x86/kernel/io_apic.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Index: b/arch/x86/kernel/io_apic.c
===================================================================
--- a/arch/x86/kernel/io_apic.c
+++ b/arch/x86/kernel/io_apic.c
@@ -4150,9 +4150,9 @@ static int __init ioapic_insert_resource
 	int i;
 	struct resource *r = ioapic_resources;
 
-	if (!r) {
+	if (!r && nr_ioapics > 0) {
 		printk(KERN_ERR
-		       "IO APIC resources could be not be allocated.\n");
+		       "IO APIC resources couldn't be allocated.\n");
 		return -1;
 	}
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/