linux-kernel - Re: [PATCH] x86: fix IO APIC resource allocation error message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 20 Mar 2009 23:36:53 +0300
From:	Cyrill Gorcunov <gorcunov@...il.com>
To:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
Cc:	Ingo Molnar <mingo@...e.hu>,
	Alan Bartlett <ajb.stxsl@...glemail.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86: fix IO APIC resource allocation error message

[Bartlomiej Zolnierkiewicz - Fri, Mar 20, 2009 at 09:27:14PM +0100]
...
| > | > Now we would have 'err' here and get out only on conflicting resource.
| > | > Did I miss something?
| > | 
| > | nr_ioapics > 0 && r == NULL ?
| > | 
| > 
| > This case happens when alloc_bootmem fails but we already panic'ed!
| > 
| > Here is what I mean
| > 
| > From ioapic_setup_resources()
| > 
| > 	if (nr_ioapics <= 0)
| > 		return NULL;
| > 
| > 	mem = alloc_bootmem(n); <- we panic here anyway
| 
| Seems like the following check is superfluous then:
| 
|         if (mem != NULL) {

Yes I believe

| 
| > 	...
| > 	ioapic_resources = res;
| 
| In either case I don't think we that failing all resource insertions
| (for all IO APICs) if only one has failed is a desirable behavior...

Indeed, which is even better

| 
| Thanks,
| Bart
| 

Your patch is already merged, so all is fine -- sorry for noise.

	- Cyrill -
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/