[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20090321143911.GA25729@elte.hu>
Date: Sat, 21 Mar 2009 15:39:11 +0100
From: Ingo Molnar <mingo@...e.hu>
To: Heiko Carstens <heiko.carstens@...ibm.com>,
Frédéric Weisbecker <fweisbec@...il.com>
Cc: Steven Rostedt <rostedt@...dmis.org>,
Sam Ravnborg <sam@...nborg.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] trace/ring_buffer: fix section mismatch warning
* Heiko Carstens <heiko.carstens@...ibm.com> wrote:
> From: Heiko Carstens <heiko.carstens@...ibm.com>
>
> With linux-next I get this:
>
> Section mismatch in reference from the function
> ring_buffer_alloc() to the function .cpuinit.text:rb_cpu_notify()
> The function ring_buffer_alloc() references the function __cpuinit
> rb_cpu_notify(). This is often because ring_buffer_alloc lacks a
> __cpuinit annotation or the annotation of rb_cpu_notify is wrong.
>
> This is a false positive since rb_cpu_notify gets only referenced
> if CONFIG_HOTPLUG_CPU=y. To get rid of the warning annotate
> ring_buffer_alloc with __ref.
>
> Signed-off-by: Heiko Carstens <heiko.carstens@...ibm.com>
> ---
> kernel/trace/ring_buffer.c | 2 +-
Frederic has beaten you to it narrowly:
09c9e84: tracing/ring-buffer: don't annotate rb_cpu_notify with __cpuinit
:)
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists