linux-kernel - Re: [PATCH 5/7] blktrace: report EBUSY correctly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090321151845.GA31890@elte.hu>
Date:	Sat, 21 Mar 2009 16:18:45 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Arnaldo Carvalho de Melo <acme@...hat.com>
Cc:	Li Zefan <lizf@...fujitsu.com>, Jens Axboe <jens.axboe@...cle.com>,
	Steven Rostedt <rostedt@...dmis.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 5/7] blktrace: report EBUSY correctly


* Arnaldo Carvalho de Melo <acme@...hat.com> wrote:

> Em Fri, Mar 20, 2009 at 09:49:08AM +0800, Li Zefan escreveu:
> > blk_trace_remove_queue() returns EINVAL if q->blk_trace == NULL,
> > but blk_trace_setup_queue() doesn't return EBUSY if q->blk_trace != NULL.
> > 
> >  # echo 0 > sdaX/trace/enable
> >  # echo 0 > sdaX/trace/enable
> >  bash: echo: write error: Invalid argument
> >  # echo 1 > sdaX/trace/enable
> >  # echo 1 > sdaX/trace/enable
> >  (should return EBUSY)
> > 
> > Signed-off-by: Li Zefan <lizf@...fujitsu.com>
> 
> Thanks for all the testing, its being really appreciated,
> 
> Acked-by: Arnaldo Carvalho de Melo <acme@...hat.com>

thanks Arnaldo - i've added your acks to tip:tracing/blktrace.

Jens, are the changes fine with you too, can i merge them into 
tracing/core, for v2.6.30?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/