linux-kernel - Re: [PATCH v2] perfcounters: record time running and time enabled for each counter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090321155202.GA6356@elte.hu>
Date:	Sat, 21 Mar 2009 16:52:02 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Paul Mackerras <paulus@...ba.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] perfcounters: record time running and time enabled
	for each counter


* Andrew Morton <akpm@...ux-foundation.org> wrote:

> > +	u64				time_enabled;
> > +	u64				time_running;
> 
> These look like times.  I see no indication (here) as to the units.
> 
> > +	u64				start_enabled;
> 
> This looks like a boolean, but it's u64.
> 
> > +	u64				start_running;
> 
> hard to say.
> 
> > +	u64				last_stopped;
> 
> probably a time, unknown units.
> 
> 
> Perhaps one of the reasons why this code is confusing is the 
> blurring between the "time" at which an event occured and the 
> "time" between the occurrence of two events.  A weakness in 
> English, I guess.  Using the term "interval" in the latter case 
> will help a lot.

What we use in the scheduler is "sum_time" or "runtime". A bit of a 
tongue twister but unambiguous.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/