linux-kernel - Re: [PATCH 15/17] block: kill end

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 21 Mar 2009 11:58:11 +0900
From:	Tejun Heo <tj@...nel.org>
To:	axboe@...nel.dk, linux-kernel@...r.kernel.org, bzolnier@...il.com
CC:	Jörg Dorchain <joerg@...chain.net>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Tim Waugh <tim@...erelk.net>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	Paul Mackerras <paulus@...ba.org>,
	Jeremy Fitzhardinge <jeremy@...source.com>,
	Grant Likely <grant.likely@...retlab.ca>,
	Markus Lidel <Markus.Lidel@...dowconnect.com>,
	David Woodhouse <dwmw2@...radead.org>,
	Pete Zaitcev <zaitcev@...hat.com>
Subject: Re: [PATCH 15/17] block: kill end_request()

Tejun Heo wrote:
> Impact: kill obsolete interface function
> 
> end_request() has been kept around for backward compatibility;
> however, it seems to be about time for it to go away.
> 
> * There aren't too many users left.
> 
> * Its use of @updtodate is pretty confusing.
> 
> * In some cases, newer code ends up using mixture of end_request() and
>   [__]blk_end_request[_all](), which is way too confusing.
> 
> So, kill it.
> 
> Most conversions are straightforward.  Noteworthy ones are...
> 
> * paride/pcd: next_request() updated to take 0/-errno instead of 1/0.
> 
> * paride/pf: pf_end_request() and next_request() updated to take
>   0/-errno instead of 1/0.
> 
> * xd: xd_readwrite() updated to return 0/-errno instead of 1/0.
> 
> * mtd/mtd_blkdevs: blktrans_discard_request() updated to return
>   0/-errno instead of 1/0.  Unnecessary local variable res
>   initialization removed from mtd_blktrans_thread().

This patch isn't correct.  Will post updated version later.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/