linux-kernel - Re: [PATCH] p54: fix SoftLED compile dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 23 Mar 2009 10:14:49 -0400
From:	"John W. Linville" <linville@...driver.com>
To:	Christian Lamparter <chunkeey@....de>
Cc:	Michael Buesch <mb@...sch.de>,
	Randy Dunlap <randy.dunlap@...cle.com>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>
Subject: Re: [PATCH] p54: fix SoftLED compile dependencies

On Sat, Mar 21, 2009 at 12:57:46AM +0100, Christian Lamparter wrote:
> This patch fixes a compile problem when the MAC80211_LEDS
> triggers are enabled but not LED class itself. 
> (which is sort of pointless, but anyway...)
> 
> Signed-off-by: Christian Lamparter <chunkeey@....de>
> ---
> mb, thank you for the tips!
> 
> Randy Dunlap can you please give this patch a try?
> 
> John, do you know where the patch form 
> Geert Uytterhoeven <geert@...ux-m68k.org> went?
> ---
> diff --git a/drivers/net/wireless/p54/Kconfig b/drivers/net/wireless/p54/Kconfig
> index 0e344ac..ee1aaca 100644
> --- a/drivers/net/wireless/p54/Kconfig
> +++ b/drivers/net/wireless/p54/Kconfig
> @@ -1,9 +1,10 @@
>  config P54_COMMON
>  	tristate "Softmac Prism54 support"
> -	depends on MAC80211 && WLAN_80211 && FW_LOADER && EXPERIMENTAL
> +	depends on MAC80211 && WLAN_80211 && EXPERIMENTAL
> +	select FW_LOADER
>  	---help---
> -	  This is common code for isl38xx based cards.
> -	  This module does nothing by itself - the USB/PCI frontends
> +	  This is common code for isl38xx/stlc45xx based modules.
> +	  This module does nothing by itself - the USB/PCI/SPI frontends
>  	  also need to be enabled in order to support any devices.
>  
>  	  These devices require softmac firmware which can be found at

This hunk looks unrelated to the changelog as well...?

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@...driver.com			might be all we have.  Be ready.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/