linux-kernel - Re: [PATCH 7/7] kmemtrace: update usage of ring_buffer_lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090323145556.GA21267@elte.hu>
Date:	Mon, 23 Mar 2009 15:55:56 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Eduard - Gabriel Munteanu <eduard.munteanu@...ux360.ro>
Cc:	rostedt@...dmis.org, compudj@...stal.dyndns.org,
	fweisbec@...il.com, penberg@...helsinki.fi,
	paulmck@...ux.vnet.ibm.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 7/7] kmemtrace: update usage of
	ring_buffer_lock_reserve()


* Eduard - Gabriel Munteanu <eduard.munteanu@...ux360.ro> wrote:

> The ring buffer API has changed a bit and kmemtrace wasn't 
> compiling anymore. This fixes the issue and allows kmemtrace to 
> build.
> 
> Signed-off-by: Eduard - Gabriel Munteanu <eduard.munteanu@...ux360.ro>

hm, kmemtrace was building and working fine in -tip:

 [root@...ebaran tracing]# head trace
 # tracer: kmemtrace
 #
 type_id 0 call_site 18446744071565600429 ptr 18446612139794190624
 type_id 0 call_site 18446744071565600392 ptr 18446612146227278976
 type_id 1 call_site 18446744071564535786 ptr 18446612146228083456
 type_id 0 call_site 18446744071565600392 ptr 18446612146240588256
 type_id 1 call_site 18446744071564535786 ptr 18446612146240893824

the build error that is fixed by you here was introduced by your 
earlier 4/7 patch in this series:

   kmemtrace: use tracepoints

So i've backmerged patch 7/7 into patch 4/7. Agreed?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/