linux-kernel - [tip:tracing/ftrace] kernel/trace/trace_functions_graph.c: fix nsecs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tip-603b9b9081ae0a1af986b9059a0a5055876ddea9@git.kernel.org>
Date:	Mon, 23 Mar 2009 16:42:27 GMT
From:	Daniel Mack <daniel@...aq.de>
To:	linux-tip-commits@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, hpa@...or.com, mingo@...hat.com,
	fweisbec@...il.com, rostedt@...dmis.org, daniel@...aq.de,
	tglx@...utronix.de, mingo@...e.hu
Subject: [tip:tracing/ftrace] kernel/trace/trace_functions_graph.c: fix nsecs_str buffer size

Commit-ID:  603b9b9081ae0a1af986b9059a0a5055876ddea9
Gitweb:     http://git.kernel.org/tip/603b9b9081ae0a1af986b9059a0a5055876ddea9
Author:     Daniel Mack <daniel@...aq.de>
AuthorDate: Mon, 23 Mar 2009 17:10:37 +0100
Committer:  Ingo Molnar <mingo@...e.hu>
CommitDate: Mon, 23 Mar 2009 17:40:51 +0100

kernel/trace/trace_functions_graph.c: fix nsecs_str buffer size

Impact: fix currently inactive buffer-overflow

In kernel/trace/trace_functions_graph.c, print_graph_duration(),
len can be as low as 1 or 2, which could make snprintf() write
beyond the buffer bounds. (Found by cppcheck, no real-world bug
occured)

Signed-off-by: Daniel Mack <daniel@...aq.de>
Cc: Steven Rostedt <rostedt@...dmis.org>
Cc: Frederic Weisbecker <fweisbec@...il.com>
LKML-Reference: <1237824637-28190-1-git-send-email-daniel@...aq.de>
Signed-off-by: Ingo Molnar <mingo@...e.hu>


---
 kernel/trace/trace_functions_graph.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/trace/trace_functions_graph.c b/kernel/trace/trace_functions_graph.c
index e876816..a305472 100644
--- a/kernel/trace/trace_functions_graph.c
+++ b/kernel/trace/trace_functions_graph.c
@@ -430,7 +430,7 @@ print_graph_duration(unsigned long long duration, struct trace_seq *s)
 	unsigned long nsecs_rem = do_div(duration, 1000);
 	/* log10(ULONG_MAX) + '\0' */
 	char msecs_str[21];
-	char nsecs_str[5];
+	char nsecs_str[8];
 	int ret, len;
 	int i;
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/