[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <alpine.DEB.2.00.0903231458490.3578@gandalf.stny.rr.com>
Date: Mon, 23 Mar 2009 15:00:08 -0400 (EDT)
From: Steven Rostedt <rostedt@...dmis.org>
To: Jaswinder Singh Rajput <jaswinder@...nel.org>
cc: Ingo Molnar <mingo@...e.hu>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -tip] trace: ring_buffer.c fix various signedness
issues
You're a little late:
http://lkml.org/lkml/2009/2/10/262
-- Steve
On Mon, 23 Mar 2009, Jaswinder Singh Rajput wrote:
> From: Jaswinder Singh Rajput <jaswinderrajput@...il.com>
> Date: Mon, 23 Mar 2009 00:02:38 +0530
> Subject: [PATCH] trace: ring_buffer.c fix various signedness issues
>
> Impact:cleanup
>
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@...il.com>
> ---
> kernel/trace/ring_buffer.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c
> index bd38c5c..114811b 100644
> --- a/kernel/trace/ring_buffer.c
> +++ b/kernel/trace/ring_buffer.c
> @@ -57,7 +57,7 @@ enum {
> RB_BUFFERS_DISABLED = 1 << RB_BUFFERS_DISABLED_BIT,
> };
>
> -static long ring_buffer_flags __read_mostly = RB_BUFFERS_ON;
> +static unsigned long ring_buffer_flags __read_mostly = RB_BUFFERS_ON;
>
> /**
> * tracing_on - enable all tracing buffers
> @@ -2466,7 +2466,7 @@ static ssize_t
> rb_simple_read(struct file *filp, char __user *ubuf,
> size_t cnt, loff_t *ppos)
> {
> - long *p = filp->private_data;
> + unsigned long *p = filp->private_data;
> char buf[64];
> int r;
>
> @@ -2482,9 +2482,9 @@ static ssize_t
> rb_simple_write(struct file *filp, const char __user *ubuf,
> size_t cnt, loff_t *ppos)
> {
> - long *p = filp->private_data;
> + unsigned long *p = filp->private_data;
> + unsigned long val;
> char buf[64];
> - long val;
> int ret;
>
> if (cnt >= sizeof(buf))
> --
> 1.6.0.6
>
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists