linux-kernel - Re: [PATCH 07/12] DRBD: main

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200903232326.31962.philipp.reisner@linbit.com>
Date:	Mon, 23 Mar 2009 23:26:31 +0100
From:	Philipp Reisner <philipp.reisner@...bit.com>
To:	Alexey Dobriyan <adobriyan@...il.com>
Cc:	linux-kernel@...r.kernel.org, gregkh@...e.de
Subject: Re: [PATCH 07/12] DRBD: main

Am Montag 23 März 2009 17:51:26 schrieb Alexey Dobriyan:
> On Mon, Mar 23, 2009 at 04:48:02PM +0100, Philipp Reisner wrote:
> > +#if CONFIG_PROC_FS
> > +	/*
> > +	 * register with procfs
> > +	 */
> > +	drbd_proc = create_proc_entry("drbd",  S_IFREG | S_IRUGO , NULL);
> > +
> > +	if (!drbd_proc)	{
> > +		printk(KERN_ERR "drbd: unable to register proc file\n");
> > +		goto Enomem;
> > +	}
> > +
> > +	drbd_proc->proc_fops = &drbd_proc_fops;
>
> Use proc_create().
>
> > +	drbd_proc->owner = THIS_MODULE;
>
> Unnecessary now.
>
> > +#else
> > +# error "Currently drbd depends on the proc file system
> > (CONFIG_PROC_FS)" +#endif
>
> You should "depends on PROC_FS" then and remove this #error.
> #ifdef would also become unnecessary.

Thanks!
I have updated my code and the patches.
http://oss.linbit.com/drbd/mainline_submission/03-23/

I will repost in a few days, after potentially more reviews

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/