linux-kernel - Re: [PATCH] kmemtrace: fix build breakage in befs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090324130926.GA11358@x200.localdomain>
Date:	Tue, 24 Mar 2009 16:09:26 +0300
From:	Alexey Dobriyan <adobriyan@...il.com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Pekka Enberg <penberg@...helsinki.fi>, eduard.munteanu@...ux360.ro,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kmemtrace: fix build breakage in befs

On Tue, Mar 24, 2009 at 10:53:46AM +0100, Ingo Molnar wrote:
> > -static inline char *alloc_secdata(void)
> > -{
> > -       return (char *)get_zeroed_page(GFP_KERNEL);
> > -}
> > -
> > -static inline void free_secdata(void *secdata)
> > -{
> > -       free_page((unsigned long)secdata);
> > -}
> > +#define alloc_secdata() (char *)get_zeroed_page(GFP_KERNEL)
> > +#define free_secdata()  free_page((unsigned long) secdata)
> 
> yep, that would be fine - but please add a comment about why they 
> are macros and what would have to be done to fix it.

Nooo!

Stick it into security.h!

> (the real fix would be to separate fs.h into fs_types.h and 
> fs_apis.h - like we did it with spinlock.h. Similarly with slab.h.)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/