linux-kernel - Re: [PATCH 2/2] fs: don't include <linux/gfp.h> to fix headers-export-check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 24 Mar 2009 14:12:09 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	Pekka Enberg <penberg@...helsinki.fi>
Cc:	mingo@...e.hu, eduard.munteanu@...ux360.ro,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] fs: don't include <linux/gfp.h> to fix headers-export-check

On Tuesday 24 March 2009, Pekka Enberg wrote:
>    
> From: Pekka Enberg <penberg@...helsinki.fi>
> 
> Impact: fix build
> 
> This patch fixes a headers-export-check failure:
> 
>   /home/mingo/tip/usr/include/linux/bsg.h:11: found __[us]{8,16,32,64} type without #include <linux/types.h>
>   /home/mingo/tip/usr/include/linux/fs.h:11: included file 'linux/gfp.h' is not exported
>   make[3]: *** [/home/mingo/tip/usr/include/linux/.check] Error 1
>   make[2]: *** [linux] Error 2
> 
> Cc: Eduard - Gabriel Munteanu <eduard.munteanu@...ux360.ro>
> Signed-off-by: Pekka Enberg <penberg@...helsinki.fi>
> ---
>  include/linux/fs.h |   16 ++++++----------
>  1 files changed, 6 insertions(+), 10 deletions(-)
> 
> diff --git a/include/linux/fs.h b/include/linux/fs.h
> index add95da..11fdc57 100644
> --- a/include/linux/fs.h
> +++ b/include/linux/fs.h
> @@ -8,7 +8,6 @@
>  
>  #include <linux/limits.h>
>  #include <linux/ioctl.h>
> -#include <linux/gfp.h>
>  
>  /*

I think a cleaner fix would be to move the include of gfp.h into the
second #include block that is part of #ifdef __KERNEL__, as is the
only user of get_zeroed_page in there.

	Arnd <><
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/