linux-kernel - Re: [PATCH 5/5] blktrace: print human-readable act

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.0903241205320.22830@gandalf.stny.rr.com>
Date:	Tue, 24 Mar 2009 12:06:14 -0400 (EDT)
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Ingo Molnar <mingo@...e.hu>
cc:	Li Zefan <lizf@...fujitsu.com>, Jens Axboe <jens.axboe@...cle.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 5/5] blktrace: print human-readable act_mask


On Tue, 24 Mar 2009, Steven Rostedt wrote:

> 
> 
> 
> On Tue, 24 Mar 2009, Ingo Molnar wrote:
> 
> > 
> > * Steven Rostedt <rostedt@...dmis.org> wrote:
> > 
> > > 
> > > 
> > > On Tue, 24 Mar 2009, Li Zefan wrote:
> > > >  
> > > > +static ssize_t blk_trace_mask2str(char *buf, int mask)
> 
> > > >  	else if (attr == &dev_attr_act_mask)
> > > > -		ret = sprintf(buf, "%#x\n", q->blk_trace->act_mask);
> > > > +		ret = blk_trace_mask2str(buf, q->blk_trace->act_mask);
> 
> 
> > > > -			value = blk_str2act_mask(buf);
> > > > -			if (value < 0)
> > > > +			value = blk_trace_str2mask(buf);
> > > 
> > > Hmm, does this compile? Doesn't blk_trace_str2mask need two parameters?
> > 
> > No, it needs one parameter.
> 
> I'm really confused now. The prototype for blk_trace_str2mask has 
> two parameters. It is used with two parameters above, but then it is used 
> here with only one parameter. The blk_str2act_mask may have one, and that 
> is what is replaced.
> 
> What am I missing?

I'm dyslexic :-p

I see now...

The proto-type is blk_trace_mask2str

but this is blk_trace_str2mask

Nevermind,

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/