linux-kernel - Re: [RFC] Correct behaviour of irq affinity?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49C93960.1090403@kernel.org>
Date:	Tue, 24 Mar 2009 12:49:52 -0700
From:	Yinghai Lu <yinghai@...nel.org>
To:	"Eric W. Biederman" <ebiederm@...ssion.com>
CC:	Rusty Russell <rusty@...tcorp.com.au>, x86@...nel.org,
	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...e.hu>
Subject: Re: [RFC] Correct behaviour of irq affinity?

Eric W. Biederman wrote:
> 
> Also now that I look at it there is one other bug in this routine
> that you have missed.  set_extra_move_desc should be called before
> we set desc->affinity, as it compares that with the new value to
> see if we are going to be running on a new cpu, and if so we may
> need to reallocate irq_desc onto a new numa node.  set_extra_move_desc
> looks a little fishy but it doesn't stand a chance if it is called
> with the wrong data.


you are right, that is introduce bycommit 22f65d31b25a320a5246592160bcb102d2791c45

Author: Mike Travis <travis@....com>
Date:   Tue Dec 16 17:33:56 2008 -0800

    x86: Update io_apic.c to use new cpumask API
    
    Impact: cleanup, consolidate patches, use new API
    
    Consolidate the following into a single patch to adapt to new
    sparseirq code in arch/x86/kernel/io_apic.c, add allocation of
    cpumask_var_t's in domain and old_domain, and reduce further
    merge conflicts.  Only one file (arch/x86/kernel/io_apic.c) is
    changed in all of these patches.
    
        0006-x86-io_apic-change-irq_cfg-domain-old_domain-to.patch
        0007-x86-io_apic-set_desc_affinity.patch
        0008-x86-io_apic-send_cleanup_vector.patch
        0009-x86-io_apic-eliminate-remaining-cpumask_ts-from-st.patch
        0021-x86-final-cleanups-in-io_apic-to-use-new-cpumask-AP.patch

will send one patch for that.

YH

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/