linux-kernel - [PATCH] kernel/module.c: fix compiler warning if CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <200903242146.n2OLkBQr004582@pogo.cesa.opbu.xerox.com>
Date:	Tue, 24 Mar 2009 14:46:11 -0700
From:	Andrew Klossner <andrew@...a.opbu.xerox.com>
To:	linux-kernel@...r.kernel.org
Subject: [PATCH] kernel/module.c: fix compiler warning if CONFIG_SMP=n

Commit 6e2b7574 causes this new compiler warning if
CONFIG_MODULE_UNLOAD=n or CONFIG_SMP=n:

kernel/module.c:2291: warning: label 'free_init' defined but not used

To fix, move the label inside the #if/#endif.

Signed-off-by: Andrew Klossner <andrew@...a.opbu.xerox.com>
---
diff --git a/kernel/module.c b/kernel/module.c
index 1196f5d..df00a1b 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -2288,8 +2288,8 @@ static noinline struct module *load_module(void __user *umod,
 	ftrace_release(mod->module_core, mod->core_size);
  free_unload:
 	module_unload_free(mod);
- free_init:
 #if defined(CONFIG_MODULE_UNLOAD) && defined(CONFIG_SMP)
+ free_init:
 	percpu_modfree(mod->refptr);
 #endif
 	module_free(mod, mod->module_init);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/