linux-kernel - Re: [PATCH 07/13] [usb] changed ioctls to unlocked

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090324220953.GA5835@kroah.com>
Date:	Tue, 24 Mar 2009 15:09:53 -0700
From:	Greg KH <greg@...ah.com>
To:	stoyboyker@...il.com
Cc:	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH 07/13] [usb] changed ioctls to unlocked

On Tue, Mar 24, 2009 at 04:12:42PM -0500, stoyboyker@...il.com wrote:
> From: Stoyan Gaydarov <stoyboyker@...il.com>
> 
> Signed-off-by: Stoyan Gaydarov <stoyboyker@...il.com>
> ---
>  drivers/usb/mon/mon_bin.c |   53 ++++++++++++++++++++++++++++++++------------
>  1 files changed, 38 insertions(+), 15 deletions(-)

NAK, you're just pushing lock_kernel() down for no good reason.

the code should be fixed to not need the lock at all.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/