linux-kernel - RE: [PATCH 12/13][Resubmit][drivers/media] changed ioctls to unlocked

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 24 Mar 2009 18:12:49 -0500
From:	"Aguirre Rodriguez, Sergio Alberto" <saaguirre@...com>
To:	"stoyboyker@...il.com" <stoyboyker@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:	"linux-media@...r.kernel.org" <linux-media@...r.kernel.org>
Subject: RE: [PATCH 12/13][Resubmit][drivers/media] changed ioctls to
 unlocked

Hi Stoyan,

> -----Original Message-----
> From: linux-media-owner@...r.kernel.org [mailto:linux-media-
> owner@...r.kernel.org] On Behalf Of stoyboyker@...il.com
> Sent: Tuesday, March 24, 2009 3:39 PM
> To: linux-kernel@...r.kernel.org
> Cc: Stoyan Gaydarov; linux-media@...r.kernel.org
> Subject: [PATCH 12/13][Resubmit][drivers/media] changed ioctls to unlocked
> 
> From: Stoyan Gaydarov <stoyboyker@...il.com>
> 
> Signed-off-by: Stoyan Gaydarov <stoyboyker@...il.com>
> ---
>  drivers/media/dvb/bt8xx/dst_ca.c |    7 +++++--
>  drivers/media/video/dabusb.c     |   11 ++++++++---
>  2 files changed, 13 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/media/dvb/bt8xx/dst_ca.c
> b/drivers/media/dvb/bt8xx/dst_ca.c
> index 0258451..d3487c5 100644
> --- a/drivers/media/dvb/bt8xx/dst_ca.c
> +++ b/drivers/media/dvb/bt8xx/dst_ca.c
> @@ -552,8 +552,10 @@ free_mem_and_exit:
>  	return result;
>  }
> 
> -static int dst_ca_ioctl(struct inode *inode, struct file *file, unsigned
> int cmd, unsigned long ioctl_arg)
> +static long dst_ca_ioctl(struct file *file, unsigned int cmd, unsigned
> long ioctl_arg)
>  {
> +	lock_kernel();
> +

Why moving to unlocked_ioctl if you're acquiring the Big Kernel Lock anyways?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/