linux-kernel - Re: [PATCH 04/13] [blackfin] changed ioctls to unlocked

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8bd0f97a0903241931r6ecba9dwc64bb803319efea4@mail.gmail.com>
Date:	Tue, 24 Mar 2009 22:31:25 -0400
From:	Mike Frysinger <vapier.adi@...il.com>
To:	stoyboyker@...il.com
Cc:	linux-kernel@...r.kernel.org, cooloney@...nel.org,
	uclinux-dist-devel@...ckfin.uclinux.org
Subject: Re: [PATCH 04/13] [blackfin] changed ioctls to unlocked

On Tue, Mar 24, 2009 at 17:12,  <stoyboyker@...il.com> wrote:
> --- a/arch/blackfin/mach-bf561/coreb.c
> +++ b/arch/blackfin/mach-bf561/coreb.c
> @@ -220,9 +220,10 @@ static int coreb_release(struct inode *inode, struct file *file)
>        return 0;
>  }
>
> -static int coreb_ioctl(struct inode *inode, struct file *file,
> -                      unsigned int cmd, unsigned long arg)
> +static long coreb_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
>  {
> +       lock_kernel();
> +
>        int retval = 0;
>        int coreb_index = 0;
>
> @@ -289,6 +290,7 @@ static int coreb_ioctl(struct inode *inode, struct file *file,
>  #endif
>        }
>
> +       unlock_kernel();
>        return retval;
>  }

there is no need to lock the kernel in here.  people have asked in the
past and we've told them that it's pointless.  simply change it to use
unlocked_ioctl.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/