linux-kernel - Re: [PATCH 06/13] [scsi] changed ioctls to unlocked

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090325042109.GP14127@parisc-linux.org>
Date:	Tue, 24 Mar 2009 22:21:09 -0600
From:	Matthew Wilcox <matthew@....cx>
To:	stoyboyker@...il.com
Cc:	linux-kernel@...r.kernel.org,
	James.Bottomley@...senPartnership.com, linux-scsi@...r.kernel.org
Subject: Re: [PATCH 06/13] [scsi] changed ioctls to unlocked

On Tue, Mar 24, 2009 at 04:12:41PM -0500, stoyboyker@...il.com wrote:
> +static long osst_ioctl(struct file * file, unsigned int cmd_in,
> +	unsigned long arg)
>  {
> +	lock_kernel();
>  	int		      i, cmd_nr, cmd_type, blk, retval = 0;

Did you try compiling this?  If so, what compiler did you use?  You
*should* have got an error about mixing code and declarations.

-- 
Matthew Wilcox				Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/