linux-kernel - Re: [PATCH 0/5] [PATCH][GIT PULL] remove unnecessary (un)likelys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090325072501.GC25833@elte.hu>
Date:	Wed, 25 Mar 2009 08:25:01 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Steven Rostedt <rostedt@...dmis.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Pekka Enberg <penberg@...helsinki.fi>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Peter Zijlstra <peterz@...radead.org>,
	Roland McGrath <roland@...hat.com>,
	Nick Piggin <nickpiggin@...oo.com.au>
Subject: Re: [PATCH 0/5] [PATCH][GIT PULL] remove unnecessary (un)likelys


* Steven Rostedt <rostedt@...dmis.org> wrote:

> ----
>  arch/x86/kernel/ptrace.c |    4 ++--
>  kernel/sched.c           |    4 ++--
>  kernel/sched_rt.c        |    2 +-
>  mm/rmap.c                |    8 ++++----
>  mm/slab.c                |    2 +-
>  mm/slob.c                |    2 +-
>  mm/slub.c                |    2 +-
>  7 files changed, 12 insertions(+), 12 deletions(-)

I commented on the ptrace one - i think we should take that one out 
or at least wait for more info.

The MM ones look correct. Maybe your kfree observation will be 
debated - but i think it's probably right that we should not special 
annotate kfree(NULL) anymore in any direction. But it's ultimately 
up to the MM folks. (I've Cc:-ed Pekka too)

The rmap and the scheduler ones definitely look correct. When you 
rebase, please include the profiler output to 3/5 too.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/