linux-kernel - Re: [PATCH 05/13] [s390] changed ioctls to unlocked

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090325125845.2923921b@osiris.boeblingen.de.ibm.com>
Date:	Wed, 25 Mar 2009 12:58:45 +0100
From:	Heiko Carstens <heiko.carstens@...ibm.com>
To:	stoyboyker@...il.com
Cc:	linux-kernel@...r.kernel.org,
	Stoyan Gaydarov <stoyboyker@...il.com>, schwidefsky@...ibm.com,
	linux-s390@...r.kernel.org
Subject: Re: [PATCH 05/13] [s390] changed ioctls to unlocked

On Tue, 24 Mar 2009 16:12:40 -0500
stoyboyker@...il.com wrote:

> From: Stoyan Gaydarov <stoyboyker@...il.com>
> 
> Signed-off-by: Stoyan Gaydarov <stoyboyker@...il.com>
> ---
>  drivers/s390/char/tape_char.c  |   47 +++++++++++++++++++++++----------
>  drivers/s390/char/vmwatchdog.c |   57 ++++++++++++++++++++++++++--------------
>  2 files changed, 70 insertions(+), 34 deletions(-)

Please resend with the comments that Jonathan made for your other
patches: first define variables then lock_kernel() and also please use
gotos.

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/