linux-kernel - Re: [PATCH] trivial: remove warning from arch/x86/kernel/kprobes.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090325123812.GA30755@elte.hu>
Date:	Wed, 25 Mar 2009 13:38:12 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Frank Seidel <fseidel@...nel.org>
Cc:	linux kernel <linux-kernel@...r.kernel.org>,
	akpm@...ux-foundation.org, Masami Hiramatsu <mhiramat@...hat.com>,
	Arjan van de Ven <arjan@...radead.org>,
	Jim Keniston <jkenisto@...ibm.com>, tglx@...utronix.de,
	mingo@...hat.com, hpa@...or.com, x86@...nel.org,
	Frank Seidel <frank@...eidel.de>
Subject: Re: [PATCH] trivial: remove warning from arch/x86/kernel/kprobes.c


* Frank Seidel <fseidel@...nel.org> wrote:

> From: Frank Seidel <frank@...eidel.de>
> 
> Remove warning (makes integer from pointer without a cast)
> from build messages.
> 
> Signed-off-by: Frank Seidel <frank@...eidel.de>
> ---
>  arch/x86/kernel/kprobes.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/arch/x86/kernel/kprobes.c
> +++ b/arch/x86/kernel/kprobes.c
> @@ -193,7 +193,7 @@ static int __kprobes can_boost(kprobe_op
>  	kprobe_opcode_t opcode;
>  	kprobe_opcode_t *orig_opcodes = opcodes;
>  
> -	if (search_exception_tables(opcodes))
> +	if (search_exception_tables((unsigned long)opcodes))
>  		return 0;	/* Page fault may occur on this address. */

fixed in the x86 tree:

  http://people.redhat.com/mingo/tip.git/README

a couple of days ago. (see the commit below)

	Ingo

---------->
>From cde5edbda8ba7d600154ce4171125a48e4d2a21b Mon Sep 17 00:00:00 2001
From: Jaswinder Singh Rajput <jaswinder@...nel.org>
Date: Wed, 18 Mar 2009 17:37:45 +0530
Subject: [PATCH] x86: kprobes.c fix compilation warning
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit

arch/x86/kernel/kprobes.c:196: warning: passing argument 1 of ‘search_exception_tables’ makes integer from pointer without a cast

Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@...il.com>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>
LKML-Reference:<49BED952.2050809@...hat.com>
LKML-Reference: <1237378065.13488.2.camel@...alhost.localdomain>
Signed-off-by: Ingo Molnar <mingo@...e.hu>
---
 arch/x86/kernel/kprobes.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/kprobes.c b/arch/x86/kernel/kprobes.c
index 4558dd3..55b9461 100644
--- a/arch/x86/kernel/kprobes.c
+++ b/arch/x86/kernel/kprobes.c
@@ -193,7 +193,7 @@ static int __kprobes can_boost(kprobe_opcode_t *opcodes)
 	kprobe_opcode_t opcode;
 	kprobe_opcode_t *orig_opcodes = opcodes;
 
-	if (search_exception_tables(opcodes))
+	if (search_exception_tables((unsigned long)opcodes))
 		return 0;	/* Page fault may occur on this address. */
 
 retry:
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/