linux-kernel - [PATCH] Re: Next March 25: staging/epl build break.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Date:	Wed, 25 Mar 2009 19:37:13 +0530
From:	Subrata Modak <tosubrata@...il.com>
To:	Greg Kroah-Hartman <gregkh@...e.de>
Cc:	Sachin Sant <sachinp@...ibm.com>,
	Subrata Modak <tosubrata@...il.com>,
	linux-next@...r.kernel.org,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	Greg KH <greg@...ah.com>, LKML <linux-kernel@...r.kernel.org>
Subject: [PATCH] Re: Next March 25: staging/epl build break.

Hi Greg,

>Today's next x86 randconfig build failed with
>
>drivers/staging/epl/VirtualEthernetLinux.c: In function VEthAddInstance:
>drivers/staging/epl/VirtualEthernetLinux.c:302: error: struct net_device has no member named open
>drivers/staging/epl/VirtualEthernetLinux.c:303: error: struct net_device has no member named stop
>drivers/staging/epl/VirtualEthernetLinux.c:304: error: struct net_device has no member named get_stats
>drivers/staging/epl/VirtualEthernetLinux.c:305: error: struct net_device has no member named hard_start_xmit
>drivers/staging/epl/VirtualEthernetLinux.c:306: error: struct net_device has no member named tx_timeout
>

The above build problem reported by Sachin can be fixed with the
patch below. However, it still will leave with the following
warnings, which i think can be ignored:

drivers/staging/epl/VirtualEthernetLinux.c:164: warning: ‘VEthOpen’ defined but not used
drivers/staging/epl/VirtualEthernetLinux.c:183: warning: ‘VEthClose’ defined but not used
drivers/staging/epl/VirtualEthernetLinux.c:196: warning: ‘VEthXmit’ defined but not used
drivers/staging/epl/VirtualEthernetLinux.c:231: warning: ‘VEthGetStats’ defined but not used
drivers/staging/epl/VirtualEthernetLinux.c:238: warning: ‘VEthTimeout’ defined but not used

>.config attached.
>
>Thanks
>-Sachin

Signed-Off-By: Subrata Modak <subrata@...ux.vnet.ibm.com>
---

--- a/linux-2.6.29/drivers/staging/epl/Kconfig	2009-03-24 04:42:14.000000000 +0530
+++ b/linux-2.6.29/drivers/staging/epl/Kconfig	2009-03-25 19:01:18.000000000 +0530
@@ -1,6 +1,7 @@
 config EPL
 	tristate "openPOWERLINK protocol stack"
 	depends on NET && HIGH_RES_TIMERS && X86
+        depends on COMPAT_NET_DEV_OPS
 	default N
 	---help---
 	  Enable support for the openPOWERLINK network protocol stack.
--- a/linux-2.6.29/drivers/staging/epl/VirtualEthernetLinux.c	2009-03-25 18:38:06.000000000 +0530
+++ b/linux-2.6.29/drivers/staging/epl/VirtualEthernetLinux.c	2009-03-25 19:03:16.000000000 +0530
@@ -299,11 +299,13 @@ tEplKernel VEthAddInstance(tEplDllkInitP
 		goto Exit;
 	}
 
+#ifdef CONFIG_COMPAT_NET_DEV_OPS
 	pVEthNetDevice_g->open = VEthOpen;
 	pVEthNetDevice_g->stop = VEthClose;
 	pVEthNetDevice_g->get_stats = VEthGetStats;
 	pVEthNetDevice_g->hard_start_xmit = VEthXmit;
 	pVEthNetDevice_g->tx_timeout = VEthTimeout;
+#endif
 	pVEthNetDevice_g->watchdog_timeo = EPL_VETH_TX_TIMEOUT;
 	pVEthNetDevice_g->destructor = free_netdev;

--
Regards--
Subrata
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/