linux-kernel - Re: [tip:tracing/kmemtrace] rcutree: fix rcu_tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090325165204.GG7297@linux.vnet.ibm.com>
Date:	Wed, 25 Mar 2009 09:52:04 -0700
From:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	linux-tip-commits@...r.kernel.org, linux-kernel@...r.kernel.org,
	hpa@...or.com, mingo@...hat.com, penberg@...helsinki.fi,
	eduard.munteanu@...ux360.ro, tglx@...utronix.de
Subject: Re: [tip:tracing/kmemtrace] rcutree: fix rcu_tree_trace.c data
	structure dependencies

On Wed, Mar 25, 2009 at 05:11:47PM +0100, Ingo Molnar wrote:
> 
> * Ingo Molnar <mingo@...e.hu> wrote:
> 
> > Commit-ID:  5d957021d326fbfdc1d7a4f11a3da1f6f82d6a36
> > Gitweb:     http://git.kernel.org/tip/5d957021d326fbfdc1d7a4f11a3da1f6f82d6a36
> > Author:     Ingo Molnar <mingo@...e.hu>
> > AuthorDate: Wed, 25 Mar 2009 16:42:24 +0100
> > Committer:  Ingo Molnar <mingo@...e.hu>
> > CommitDate: Wed, 25 Mar 2009 16:42:24 +0100
> > 
> > rcutree: fix rcu_tree_trace.c data structure dependencies
> > 
> > Impact: build fix
> > 
> > We removed rcutree internals from the public rcutree.h file - but
> > kernel/rcutree_trace.c depends on them.
> > 
> > Introduce kernel/rcutree.h for internal definitions. (Probably all
> > the other data types from include/linux/rcutree.h could be
> > moved here too - except rcu_data.)
> 
> Paul ... what do you think? This is just an interim measure to get 
> the build going - i think we could do more cleanups here perhaps, if 
> you agree.

I am generally in favor of this.  I reviewed the above gitweb and it
looks good to me, feel free to append:

Reviewed-by: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>

> I think many of the data definitions (and the resulting include file 
> dependencies) in include/linux/rcu*.h could move into kernel/rcu*.h 
> and be privatized that way. 'struct rcu_state' would be an example.
> 
> Agreed?

In principle, yes.  In practice, my attempts to make headway in this
direction have usually collided with the desire to inline some of the
functions that appear on fastpaths, so I would prefer caution when moving
in this direction, especially given my treercu-related todos, to which
"speeding up synchronize_rcu()" just got added.

							Thanx, Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/