linux-kernel - Re: [PATCH] reiserfs: select CRC32 and BITREVERSE for REISERFS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 26 Mar 2009 01:22:30 +0800
From:	Coly Li <coly.li@...e.de>
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] reiserfs: select CRC32 and BITREVERSE for REISERFS_FS
 Kconfig entry



Randy Dunlap Wrote:
> Coly Li wrote:
>> In patch fs-reiserfs-return-f_fsid-for-statfs2-v2.patch (from mmotm), crc32_le()
>> is referenced. If reiserfs is compiled into kernel and crc32_le() is compiled as
>> kernel module, there might be a compiling error as:
>>     fs/built-in.o: In function `reiserfs_statfs':
>>     super.c:(.text+0x7332b): undefined reference to `crc32_le'
>>     super.c:(.text+0x7333f): undefined reference to `crc32_le'
>> This patch select CRC32 and BITREVERSE for REISERFS_FS Kconfig entry, which
>> indicates compiling crc32_le() into kernel.
>>
>> Thanks to Randy Dunlap for pointing out this error and providing helpful solution.
>>
>> Signed-off-by: Coly Li <coly.li@...e.de>
>> Cc: Randy Dunlap <randy.dunlap@...cle.com>
> 
> Acked-by: Randy Dunlap <randy.dunlap@...cle.com>
> Tested-by: Randy Dunlap <randy.dunlap@...cle.com>

Hi Randy,

You give me an important enlightenment, for my return-f_fsid-for-statfs2 patch
serial, selecting CRC32 and BITREVERSE is necessary ...

Andrew,

I will check it and send out fix ASAP.

Thanks.

-- 
Coly Li
SuSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/