linux-kernel - Re: [PATCH 2/5][RFC] tracing: move function profiler data out of function struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.0903251439180.5675@gandalf.stny.rr.com>
Date:	Wed, 25 Mar 2009 14:40:08 -0400 (EDT)
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Ingo Molnar <mingo@...e.hu>
cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Peter Zijlstra <peterz@...radead.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Tim Bird <tim.bird@...sony.com>,
	Steven Rostedt <srostedt@...hat.com>
Subject: Re: [PATCH 2/5][RFC] tracing: move function profiler data out of
 function struct


On Wed, 25 Mar 2009, Ingo Molnar wrote:

> 
> * Steven Rostedt <rostedt@...dmis.org> wrote:
> 
> > struct ftrace_profile {
> > 	struct hlist_node	*node;
> > 	unsigned long		ip;
> > 	unsigned long		hit;
> > 	unsigned long long	calltime;
> > };
> > 
> > on x86_64 that is 40 bytes. (node is 16, ip is 8, hit is 8, calltime is 8)
> 
> node is a pointer so it's 8 bytes - so the whole thing is 32 bytes. 
> Acceptable IMO - and could be compressed further if needed.

that was me doing the struct from memory. Because I had already switched 
out of that branch :-/

It is really a struct hlist_node node; not a pointer. My mistake.

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/