linux-kernel - Re: [PATCH] mmc: align data size for host which only supports power-of-2 block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090325202335.42abc221@mjolnir.ossman.eu>
Date:	Wed, 25 Mar 2009 20:23:35 +0100
From:	Pierre Ossman <drzeus-mmc@...eus.cx>
To:	"Cai, Cliff" <Cliff.Cai@...log.com>
Cc:	"Bryan Wu" <cooloney@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mmc: align data size for host which only supports
 power-of-2 block

On Wed, 25 Mar 2009 11:22:25 +0800
"Cai, Cliff" <Cliff.Cai@...log.com> wrote:

> >
> >This patch seems premature as there is no associated 
> >modification of any of the host drivers.
> 
> The SDH on Blackfin BF54x/BF51x only supports power-of-2 block
> transfer,we will soon
> Send the sdh driver to mainline as well.
> 

Ok. Looking forward to it. :)

> >Padding to a power of two size can also mean a rather large 
> >padding. We might need to check the host data limits after 
> >doing the adjustment.
> 
> Yes,but it's the higher level driver's job. 
> 

mmc_align_data_size() shouldn't be adjusting the size to something it
can easily determine that it's invalid.

Rgds
-- 
     -- Pierre Ossman

  Linux kernel, MMC maintainer        http://www.kernel.org
  rdesktop, core developer          http://www.rdesktop.org

  WARNING: This correspondence is being monitored by the
  Swedish government. Make sure your server uses encryption
  for SMTP traffic and consider using PGP for end-to-end
  encryption.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/