linux-kernel - Re: [PATCH] writeback: reset inode dirty time when adding it back to empty s

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1238011622.5676.3.camel@think.oraclecorp.com>
Date:	Wed, 25 Mar 2009 16:07:02 -0400
From:	Chris Mason <chris.mason@...cle.com>
To:	"hch@...radead.org" <hch@...radead.org>
Cc:	Wu Fengguang <fengguang.wu@...el.com>,
	Jeff Layton <jlayton@...hat.com>, Ian Kent <raven@...maw.net>,
	Dave Chinner <david@...morbit.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
	"jens.axboe@...cle.com" <jens.axboe@...cle.com>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"linux-nfs@...r.kernel.org" <linux-nfs@...r.kernel.org>
Subject: Re: [PATCH] writeback: reset inode dirty time when adding it back
 to empty s_dirty list

On Wed, 2009-03-25 at 12:55 -0400, hch@...radead.org wrote:
> On Wed, Mar 25, 2009 at 08:17:43PM +0800, Wu Fengguang wrote:
> > Now there are now two possible solutions:
> > - unconditionally update dirtied_when in redirty_tail();
> > - keep dirtied_when and redirty inodes to a new dedicated queue.
> > The first one involves less code, the second one allows more flexible timing.
> > 
> > NFS/XFS could be a good starting point for discussing the
> > requirements, so that we can reach a suitable solution.
> 
> Note that the XFS requirement also applies to all filesystems that
> perform some sort of metadata updats on I/O completeion.  That includes
> at least ext4, btrfs and most likely the cluster filesystems too.

btrfs at least doesn't dirty the inode on I/O completion.  It just puts
the changes directly into the btree blocks.

-chris


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/