linux-kernel - Re: [PATCH] hpfall.c improvements, thoughts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090325213345.GD6708@elf.ucw.cz>
Date:	Wed, 25 Mar 2009 22:33:46 +0100
From:	Pavel Machek <pavel@....cz>
To:	Christian Thaeter <ct@...apo.org>
Cc:	linux-kernel@...r.kernel.org, eric.piel@...mplin-utc.net
Subject: Re: [PATCH] hpfall.c improvements, thoughts

Hi!

> Some conversation I had with Pavel,
> 
> imo the example code should be at least barely useable as in not causing
> harm like I sketched in (1.). Maybe someone else picks that up and
> improves it later on. Patch at the end, quite sketchy and imature as it
> doesn't check for errors, but certainly better than before.

Thanks. Acked-by: Pavel Machek <pavel@....cz>
									Pavel


> Signed-off-by: Christian Thaeter <ct@...apo.org>
> ---
> 
> diff --git a/Documentation/hwmon/hpfall.c b/Documentation/hwmon/hpfall.c
> index bbea1cc..f3cde67 100644
> --- a/Documentation/hwmon/hpfall.c
> +++ b/Documentation/hwmon/hpfall.c
> @@ -16,6 +16,8 @@
>  #include <stdint.h>
>  #include <errno.h>
>  #include <signal.h>
> +#include <sys/mman.h>
> +#include <sched.h>
> 
>  void write_int(char *path, int i)
>  {
> @@ -63,6 +65,7 @@ void ignore_me(void)
>  int main(int argc, char* argv[])
>  {
>         int fd, ret;
> +       struct sched_param param;
> 
>         fd = open("/dev/freefall", O_RDONLY);
>         if (fd < 0) {
> @@ -70,7 +73,12 @@ int main(int argc, char* argv[])
>                 return EXIT_FAILURE;
>         }
> 
> -	signal(SIGALRM, ignore_me);
> +       daemon(0,0);
> +       param.sched_priority = sched_get_priority_max(SCHED_FIFO);
> +       sched_setscheduler(0, SCHED_FIFO, &param);
> +       mlockall(MCL_CURRENT|MCL_FUTURE);
> +
> +       signal(SIGALRM, ignore_me);
> 
>         for (;;) {
>  	       unsigned char count;

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/