linux-kernel - [PATCH] lib: statically link find_last

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <49CB6597.9060607@panasas.com>
Date:	Thu, 26 Mar 2009 13:23:03 +0200
From:	Benny Halevy <bhalevy@...asas.com>
To:	pNFS Mailing List <pnfs@...ux-nfs.org>
CC:	Fredric Isaman <iisaman@...i.umich.edu>,
	Steve Dickson <steved@...hat.com>,
	lkml <linux-kernel@...r.kernel.org>
Subject: [PATCH] lib: statically link find_last_bit

Currently, the only use of find_last_bit in the kernel is
setup_nr_cpu_ids which compiles only under CONFIG_SMP.
On uniprocessor machines the linker can't find it when
needed in a loadable module.

    Kernel: arch/x86/boot/bzImage is ready  (#5)
      Building modules, stage 2.
      MODPOST 515 modules
    ERROR: "find_last_bit" [fs/nfs/nfs.ko] undefined!

Cc: Fredric Isaman <iisaman@...i.umich.edu>
Signed-off-by: Benny Halevy <bhalevy@...asas.com>
---

patch required for the nfs41 series

 lib/Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/Makefile b/lib/Makefile
index 32b0e64..286e2f7 100644
--- a/lib/Makefile
+++ b/lib/Makefile
@@ -37,7 +37,7 @@ lib-$(CONFIG_RWSEM_GENERIC_SPINLOCK) += rwsem-spinlock.o
 lib-$(CONFIG_RWSEM_XCHGADD_ALGORITHM) += rwsem.o
 lib-$(CONFIG_GENERIC_FIND_FIRST_BIT) += find_next_bit.o
 lib-$(CONFIG_GENERIC_FIND_NEXT_BIT) += find_next_bit.o
-lib-$(CONFIG_GENERIC_FIND_LAST_BIT) += find_last_bit.o
+obj-$(CONFIG_GENERIC_FIND_LAST_BIT) += find_last_bit.o
 obj-$(CONFIG_GENERIC_HWEIGHT) += hweight.o
 obj-$(CONFIG_LOCK_KERNEL) += kernel_lock.o
 obj-$(CONFIG_PLIST) += plist.o
-- 
1.6.2.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/