linux-kernel - Re: [PATCH -tip] x86: unification of cpu/bugs.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090326131236.GE3226@erda.amd.com>
Date:	Thu, 26 Mar 2009 14:12:36 +0100
From:	Robert Richter <robert.richter@....com>
To:	Jaswinder Singh Rajput <jaswinder@...nel.org>
CC:	Ingo Molnar <mingo@...e.hu>, x86 maintainers <x86@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Andi Kleen <andi@...stfloor.org>
Subject: Re: [PATCH -tip] x86: unification of cpu/bugs.c

On 26.03.09 17:32:09, Jaswinder Singh Rajput wrote:
> This patch is based on -tip x86/core:
> 
> From: Jaswinder Singh Rajput <jaswinderrajput@...il.com>
> Date: Thu, 26 Mar 2009 17:14:38 +0530
> Subject: [PATCH] x86: unification of cpu/bugs.c
> 
> Impact: Unification, cleanup
> 
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@...il.com>
> ---
>  arch/x86/kernel/cpu/Makefile  |    5 +--
>  arch/x86/kernel/cpu/bugs.c    |   74 ++++++++++++++++++++++++++--------------
>  arch/x86/kernel/cpu/bugs_64.c |   33 ------------------
>  3 files changed, 50 insertions(+), 62 deletions(-)
>  delete mode 100644 arch/x86/kernel/cpu/bugs_64.c

Jaswinder,

please send separate patches for separate changes (e.g. make separate
whitespace changes).

[...]

> @@ -91,14 +98,14 @@ static void __init check_hlt(void)
>  
>  	printk(KERN_INFO "Checking 'hlt' instruction... ");
>  	if (!boot_cpu_data.hlt_works_ok) {
> -		printk("disabled\n");
> +		printk(KERN_INFO "disabled\n");

All this is continuing the printk above.

-Robert

>  		return;
>  	}
>  	halt();
>  	halt();
>  	halt();
>  	halt();
> -	printk("OK.\n");
> +	printk(KERN_INFO "OK.\n");
>  }
>  
>  /*
> @@ -122,9 +129,9 @@ static void __init check_popad(void)
>  	 * CPU hard. Too bad.
>  	 */
>  	if (res != 12345678)
> -		printk("Buggy.\n");
> +		printk(KERN_INFO "Buggy.\n");
>  	else
> -		printk("OK.\n");
> +		printk(KERN_INFO "OK.\n");
>  #endif
>  }
>  

[...]

-- 
Advanced Micro Devices, Inc.
Operating System Research Center
email: robert.richter@....com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/