linux-kernel - Re: [PATCH -tip] x86: unification of cpu/bugs.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 26 Mar 2009 19:59:54 +0530
From:	Jaswinder Singh Rajput <jaswinder@...nel.org>
To:	Robert Richter <robert.richter@....com>
Cc:	Ingo Molnar <mingo@...e.hu>, x86 maintainers <x86@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Andi Kleen <andi@...stfloor.org>
Subject: Re: [PATCH -tip] x86: unification of cpu/bugs.c

On Thu, 2009-03-26 at 15:12 +0100, Robert Richter wrote:
> > +/*
> > + * Check various bugs
> > + */
> > +static void __init check_various_bugs(void)
> > +{
> > +	check_config();
> > +	check_fpu();
> > +	check_hlt();
> > +	check_popad();
> > +

This is applicable to 32 bit only. right ?

> > +	init_utsname()->machine[1] =
> > +		'0' + (boot_cpu_data.x86 > 6 ? 6 : boot_cpu_data.x86);
> 

hmm. this can be common.

> Did you evaluate why these functions are 32 bit only? Same applies to
> 64 bit below. It seems this is not a unification and instead only some
> move-around of code.
> 

Thanks for pointing.

--
JSR


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/