linux-kernel - Re: RDMA/nes: Fix mis-merge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.0903261639150.3994@localhost.localdomain>
Date:	Thu, 26 Mar 2009 16:41:15 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	David Miller <davem@...emloft.net>
cc:	rdreier@...co.com, akpm@...ux-foundation.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: RDMA/nes: Fix mis-merge

On Thu, 26 Mar 2009, Linus Torvalds wrote:

> 
> 
> On Thu, 26 Mar 2009, David Miller wrote:
> > 
> > Acked-by: David S. Miller <davem@...emloft.net>
> 
> Can I get a sign-off from Roland too?

Btw, as far as I can tell, that function had never been tested with any 
polling. It had a line like

	netif_napi_add(netdev, &nesvnic->napi, nes_netdev_poll, 128);

but that line was _before_ 'nesvnic' was actually initialized (well, it 
had been initialized to NULL, so it passed in some NULL-pointer-offset to 
that function).

I moved that initialization up in the merge, but I obviously didn't test 
anything. So I'd suggest somebody actually test this case, because it 
clearly must have  gotten no testing at all.

			Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/