lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 26 Mar 2009 16:53:25 -0700 From: Roland Dreier <rdreier@...co.com> To: Linus Torvalds <torvalds@...ux-foundation.org> Cc: David Miller <davem@...emloft.net>, akpm@...ux-foundation.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: RDMA/nes: Fix mis-merge > Btw, as far as I can tell, that function had never been tested with any > polling. It had a line like > > netif_napi_add(netdev, &nesvnic->napi, nes_netdev_poll, 128); > > but that line was _before_ 'nesvnic' was actually initialized (well, it > had been initialized to NULL, so it passed in some NULL-pointer-offset to > that function). Yes, looks like the bug was introduced by d0929553 ("infiniband: convert nes driver to net_device_ops"). And unfortunately the nesvnic=NULL initialization stopped gcc from warning about used-uninitialized I guess. I'll test the final merge out... - R. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists